RemoteEdit Draft Management and Recovery - #241

Please address the comments from this code review:

## Overall Comments
- The async task loop in RemoteEdit::addSession/RemoteEdit::recoverDrafts relies on RemoteEditSession::shouldStopTask without any synchronization, which can lead to data races between the worker thread and the GUI thread; consider using an atomic flag or another thread-safe mechanism for signalling task termination.
- RemoteEditExternalSession currently passes getFullDraftPath() (which is empty at construction time) into RemoteEditProcess, so external edit sessions fall back to a temp file instead of the provisioned draft path; you likely want to provision the draft and set m_draftFileName before constructing RemoteEditExternalSession so the external editor uses the persistent draft file.
- In connectionlistener.h, replacing the forward declaration of Proxy with a local #include "proxy.h" inside the forward-declarations block introduces a tighter header coupling and potential circular-dependency issues; it would be cleaner to restore the forward declaration and move the include to the top of the file only where a full definition is needed.

## Individual Comments

### Comment 1
<location path="src/mpi/remoteedit.cpp" line_range="74-83" />
<code_context>
+    if (isEdit) {
</code_context>
<issue_to_address>
**issue (bug_risk):** Async task lambda holds a raw session pointer, which can dangle when the session is removed.

In `addSession()`, the RemoteEdit async task captures `auto* pSession = session.get()` by value and uses it in a long-running loop. In `removeSession()`, `stopTask()` is called and the session is erased from `m_sessions`, destroying the `shared_ptr` and the session object while the async thread may still access `pSession->shouldStopTask()`, leading to undefined behavior. The recovered-drafts path correctly captures a `std::shared_ptr` and uses `get()` only inside the lambda. Please change the regular edit path to capture a `std::shared_ptr<RemoteEditSession>` (or otherwise ensure the task owns the session and the session outlives the task).
</issue_to_address>

### Comment 2
<location path="src/mpi/remoteedit.cpp" line_range="346-349" />
<code_context>
+    return false;
+}
+
+void RemoteEdit::deleteDraft(const QString &fileName)
+{
+    if (fileName.isEmpty()) return;
+    QFile::remove(QDir(getDraftDirectory()).absoluteFilePath(fileName));
+}
+
</code_context>
<issue_to_address>
**suggestion (bug_risk):** deleteDraft silently ignores failure to remove the draft file.

If the draft directory isn’t writable or the file can’t be removed, `deleteDraft` fails silently. Since drafts drive recovery (`discoverDrafts`), leftover files could cause confusing behaviour (e.g. tasks “recovered” after being cancelled). Please log a warning when `QFile::remove` returns false to aid diagnosing editorDirectory or filesystem permission issues.

Suggested implementation:

```cpp
void RemoteEdit::deleteDraft(const QString &fileName)
{
    if (fileName.isEmpty()) {
        return;
    }

    const QString draftPath = QDir(getDraftDirectory()).absoluteFilePath(fileName);
    QFile draftFile(draftPath);

    if (!draftFile.remove()) {
        qWarning() << "RemoteEdit::deleteDraft: failed to remove draft file"
                   << draftPath
                   << "- error:" << draftFile.errorString();
    }
}

```

If `qWarning` or `QFile`/`QDir` are not yet included in this translation unit, you may need to ensure the appropriate Qt headers are present (typically `<QFile>`, `<QDir>`, and, if required by your logging setup, `<QDebug>` or `<QtGlobal>`). Align the logging style with the rest of the file (e.g. if it uses a custom logging helper or `QLoggingCategory`, adapt the `qWarning` call accordingly).
</issue_to_address>